Skip to content
This repository has been archived by the owner on Sep 17, 2019. It is now read-only.

Traceroute: add vrf arg #71

Merged
merged 2 commits into from
Feb 20, 2017
Merged

Traceroute: add vrf arg #71

merged 2 commits into from
Feb 20, 2017

Conversation

mirceaulinic
Copy link
Member

Solves #70

@mirceaulinic mirceaulinic added this to the 0.5.1 milestone Feb 7, 2017
@mirceaulinic
Copy link
Member Author

Weird error, that I'm not seeing in my env: https://travis-ci.org/napalm-automation/napalm-nxos/jobs/199103340

@dbarrosop
Copy link
Member

Yeah, I have started to see that one as well. Fixing it is as simple from changing:

try:
    bla
except:
    ble

to:

try:
    bla
except Exception:
    ble

@mirceaulinic
Copy link
Member Author

I have suspected that as well, but I didn't see that chunk of config catching the generic exception. I will double check.

@dbarrosop
Copy link
Member

Here:

@mirceaulinic
Copy link
Member Author

Thanks @dbarrosop

@coveralls
Copy link

coveralls commented Feb 20, 2017

Coverage Status

Coverage remained the same at 67.219% when pulling 6505242 on solves-70 into 53721a9 on develop.

@mirceaulinic mirceaulinic merged commit 346cdbd into develop Feb 20, 2017
@ktbyers ktbyers deleted the solves-70 branch August 2, 2017 22:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants