Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LLDP Neighbor update #40

Merged
merged 3 commits into from Mar 1, 2017
Merged

LLDP Neighbor update #40

merged 3 commits into from Mar 1, 2017

Conversation

itdependsnetworks
Copy link
Collaborator

Test if no lldp neighbor is found

pinging @XioNoX since it looks like he implemented for input.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 59.437% when pulling f4a2fe1 on itdependsnetworks:patch-1 into bc55c7f on napalm-automation:develop.

1 similar comment
@coveralls
Copy link

coveralls commented Feb 27, 2017 •
edited

Coverage Status

Coverage increased (+0.3%) to 59.437% when pulling f4a2fe1 on itdependsnetworks:patch-1 into bc55c7f on napalm-automation:develop.

@XioNoX
Copy link
Contributor

XioNoX commented Feb 27, 2017

I don't have any PAN device with no LLDP neighbors so I can't test it. But that looks good.

@dbarrosop
Copy link
Contributor

@GGabriele could you take a look when you have the time?

Thanks!

@dbarrosop dbarrosop requested a review from GGabriele March 1, 2017 06:27
@GGabriele
Copy link
Collaborator

@dbarrosop Tested and worked. Thanks @itdependsnetworks !

@GGabriele GGabriele merged commit 1425fc3 into napalm-automation-community:develop Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GGabriele GGabriele Awaiting requested review from GGabriele

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@itdependsnetworks @coveralls @XioNoX @dbarrosop @GGabriele