This repository has been archived by the owner on May 15, 2019. It is now read-only.
Correctly append list of command results #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbarrosop
reviewed
Nov 17, 2017
napalm_yang/parser.py
Outdated
|
|
||
| result.append(r) | ||
| if isinstance(r, list): | ||
| result += r |
There was a problem hiding this comment.
could you do instead result.extend(r)? I think it's easier to read,
In the _execute_methods function, if the results are returned as a list they were being appended to the results list. So there would be a list inside the results list, which would later cause an error while trying to decode the results. This happens when parsing state against an Arista device. See napalm-automation#103
tcaiazza
force-pushed
the
eosStateBug
branch
from
cb45164
to
47472bd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the _execute_methods function, if the results are returned as a list
they were being appended to the results list. So there would be a list
inside the results list, which would later cause an error while trying
to decode the results. This happens when parsing state against an
Arista device. See
#103
If there is a better way to do this let me know and I'll adjust the PR.