This repository has been archived by the owner on May 15, 2019. It is now read-only.
Add Basic Ethernet State parsing for NXOS and EOS #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some useful states in the oc-ethernet model, like crc errors, that aren't currently being pulled in by the oc-interface state parsing. These changes will add some of these useful ethernet stats/states As part of the parsing of the nxos mac addresses I needed a way to convert cisco style mac addresses into unix style, so I added a jinja filter to do that. Also added a note to the writing profiles section of the docs about writing parsers for models that are called by other models not needing to execute commands.
|
Awesome work as usual :D |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some useful states in the oc-ethernet model, like crc errors, that aren't currently being pulled in by the oc-interface state parsing. These changes will add some of these useful ethernet stats/states.
Along with the basic parser changes I added a new jinja filter. With the nxos mac addresses I needed a way to convert cisco style mac addresses into unix style, so I added a jinja
filter to do that.
Also added a note to the writing profiles section of the docs about writing parsers for models that are called by other models not needing to execute commands.