Update base._to_dict_leaf function to display lists #130
Conversation
In cases where the final leaf element is a list the to dict function was not properly translating the lists. The trunk vlans in the interface model and the ip addresses under the systems host entries are two examples. This change will set the value to the `_list` element if it is present otherwise continue on with current behavior
| @@ -378,6 +378,9 @@ def _to_dict_leaf(element, filter): | |||
| try: | |||
| value = ast.literal_eval(element.__repr__()) | |||
| except Exception: | |||
| value = element.__repr__() | |||
| if hasattr(element, '_list'): | |||
There was a problem hiding this comment.
I think we should move this to the try block:
try:
if hasattr(element, '_list'):
value = element._list
else:
value = ast.literal_eval(element.__repr__())
except Exception:
...
|
With the exception of the tiny comment I made I think it looks sane :) |
|
Might also be great to add a test if you have the time ;) |
|
@dbarrosop These tests would go under test/unit/test_parser/leaf/ correct? |
|
I would just add a new test similar to this: https://github.com/napalm-automation/napalm-yang/blob/develop/test/unit/test_text_tree.py Where you load an object (no need to parse a real config, just load_dict from a json should be fine) and then dumping it. That'd actually test that we can serlialize and deserialize lists. |
|
Ok, fixed it here: 3d4e600 Note that I will be releasing 0.1.0 next and this one will include py3 support and will make use of the upstream version of pyangbind 0.8.0. I'd recommend testing carefully :) |
|
Thanks for the heads up on the py3 stuff. I've started testing, no issues so far. |
In cases where the final leaf element is a list the to dict function was
not properly translating the lists.
The trunk vlans in the interface model and the ip addresses under the
systems host entries are two examples.
This change will set the value to the
_listelement if it is presentotherwise continue on with current behavior
This PR is in response to
#129