Skip to content
This repository has been archived by the owner on May 15, 2019. It is now read-only.

Fix junos unique routing-options container #148

Merged
merged 2 commits into from
Sep 7, 2018

Conversation

ckishimo
Copy link
Contributor

In the default test case in the openconfig-network-instance you can find different routing-options containers for the AS, the router-id and the static routes, like:

  <routing-options>
    <autonomous-system>
      <as-number>65000</as-number>
    </autonomous-system>
  </routing-options>
  <routing-options>
    <router-id>1.1.1.1</router-id>
  </routing-options>
  <routing-options>
    <static>
      <route>
        <name>10.0.0.0/24</name>
        <qualified-next-hop>
          <name>192.168.100.100</name>
          <metric>100</metric>
        </qualified-next-hop>
        <qualified-next-hop>
          <name>192.168.100.101</name>
          <metric>200</metric>
        </qualified-next-hop>
      </route>
      <route>
        <name>10.100.0.0/24</name>
        <qualified-next-hop>
          <name>192.168.100.200</name>
        </qualified-next-hop>
      </route>
    </static>
  </routing-options>

However there should be a unique routing-options container, like:

  <routing-options>
    <autonomous-system>
      <as-number>65000</as-number>
    </autonomous-system>
    <router-id>1.1.1.1</router-id>
    <static>
      <route>
        <name>10.0.0.0/24</name>
        <qualified-next-hop>
          <name>192.168.100.100</name>
          <metric>100</metric>
        </qualified-next-hop>
        <qualified-next-hop>
          <name>192.168.100.101</name>
          <metric>200</metric>
        </qualified-next-hop>
      </route>
      <route>
        <name>10.100.0.0/24</name>
        <qualified-next-hop>
          <name>192.168.100.200</name>
        </qualified-next-hop>
      </route>
    </static>
  </routing-options>

This PR should fix this...

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.067% when pulling 3909672 on ckishimo:routing into 4a6eeb3 on napalm-automation:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.067% when pulling 3909672 on ckishimo:routing into 4a6eeb3 on napalm-automation:develop.

@dbarrosop dbarrosop merged commit 17679cd into napalm-automation:develop Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants