This repository has been archived by the owner on May 15, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 46
Add prefix and negate_prefix to container #67
Merged
dbarrosop
merged 10 commits into
napalm-automation:develop
from
ArnesSI:container-prefix-attr
Jul 3, 2017
Merged
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d70d0c3
text translator - add prefix and negate_prefix to container
matejv b9d758d
update eos translator to use prefix and negate_prefix
matejv 0de89fb
forgot to pass extra_vars to resolve_rule in _translate_leaf
matejv f35d342
restore previous extra_vars when leaving current tree branch
matejv 4f02079
read *prefix attributes from containers that are being defaulted
matejv adfa260
eos static route translator bugfix
matejv daf3e9b
update test mock data
matejv ca24114
fix handling return values from translator methods
matejv 213d7a6
update eos replace integration test
matejv 438cfb7
expose replacing, negating and merging variables in template expressions
matejv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a container without
key_value
you'll get an empty<command/>
element in the XML document. In that caseelement.text
is None and the next line crashes.I'll see if I can avoid creating the element in such cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably cleaner to do:
But it doesn't matter, both do the same.