Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_isis_neighbors #525

Closed
afourmy opened this issue Nov 16, 2017 · 5 comments
Closed

get_isis_neighbors #525

afourmy opened this issue Nov 16, 2017 · 5 comments
Assignees
Milestone

Comments

@afourmy
Copy link
Contributor

afourmy commented Nov 16, 2017

Do you think it would make sense to have a get_isis_neighbors as a new getter ? The format could be something like: (list of dict like get_ipv6_neighbors format)

        [
            {
                'interface' : 'Gi0/1/1.1501',
                'ip'        : '192.168.244.17',
                'state'     : 'UP',
                'hostname'  : 'test0',
                'type'      : 'L2'
            },
            {
                'interface' : 'Te2/0/0.1501',
                'ip'        : '192.168.244.189',
                'state'     : 'UP',
                'hostname'  : 'test1',
                'type'      : 'L2'
            }
        ]

Any suggestions to change the format is welcome.
I would need it for my work so I can implement it for ios to begin with, then maybe junos too.

@mirceaulinic
Copy link
Member

mirceaulinic commented Nov 16, 2017

Hi @afourmy - In my opinion it would be nice to have that. Can you propose a complete structure that you think it would be suitable and then we start to discuss?
I think at least the following fields would be interesting too:

  • System ID
  • Uptime
  • Area address

Others?

@afourmy
Copy link
Contributor Author

afourmy commented Nov 16, 2017

Hello @mirceaulinic OK for these three fields. (no hostname needed then as the system ID and hostname should be more or less the same). We can also add the SNPA if you think it's useful.

So far we would have something like:

[
    {
        'interface'   : 'Gi0/1/1.1501',
        'ip'          : '192.168.244.17',
        'state'       : 'UP',
        'system_id'   : 'test0',
        'type'        : 'L2',
        'area_address : '...',
        'uptime'      : '...'
        'snpa'        : 'some mac address usually'
    },
    {
        'interface'   : 'Te2/0/0.1501',
        'ip'          : '192.168.244.189',
        'state'       : 'UP',
        'system-id'   : 'test1',
        'type'        : 'L2',
        'area_address : '...',
        'uptime'      : '...'
        'snpa'        : 'some mac address usually'
    }
]

Also maybe it could be dictionnary which keys are the System-ID.

@dbarrosop
Copy link
Member

Is there any openconfig model we can just copy?

@jamesboswell
Copy link
Contributor

Perhaps this should be get_isis_adjacency? That's the term used in IOS-XR and JUNOS for sure, both are show isis adjacency on CLI.

Also there is an openconfig model https://github.com/openconfig/public/blob/master/release/models/isis/openconfig-isis.yang#L1450

I think this thread might be relevant here robshakir/pyangbind#135

I'm poking around on this, I've got some learning to do re: generating the napalm-yang model. @dbarrosop if you have any pointers, I'd be glad to take a swing at this

@mirceaulinic
Copy link
Member

I don't think anyone is working on this. Otherwise, please comment / open a separate issue, or even submit a PR (with the mention that it should provide the implementation of at least 3 core platforms).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants