Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS: Return empty dictionary if BGP not running #1019

Merged
merged 2 commits into from Oct 29, 2019
Merged

Conversation

bewing
Copy link
Member

@bewing bewing commented Jul 15, 2019

If BGP is not active (looking for specific strings in output), just
return an empty dictionary. Update unit testing to allow for empty
dictionary returns (global key should only exist if the dictionary is
not empty). Closes #987

If BGP is not active (looking for specific strings in output), just
return an empty dictionary.  Update unit testing to allow for empty
dictionary returns (global key should only exist if the dictionary is
not empty). Closes #987
@coveralls
Copy link

coveralls commented Jul 15, 2019

Coverage Status

Coverage increased (+0.02%) to 81.327% when pulling 7e8c2e3 on iss987 into 698cfd7 on develop.

@mirceaulinic mirceaulinic added this to the 3.0.0 milestone Oct 29, 2019
Copy link
Member

@mirceaulinic mirceaulinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mirceaulinic mirceaulinic merged commit f3a1edc into develop Oct 29, 2019
@mirceaulinic mirceaulinic deleted the iss987 branch October 29, 2019 10:51
ExaneServerTeam pushed a commit to ExaneServerTeam/napalm that referenced this pull request Mar 6, 2020
If BGP is not active (looking for specific strings in output), just
return an empty dictionary.  Update unit testing to allow for empty
dictionary returns (global key should only exist if the dictionary is
not empty). Closes napalm-automation#987
neelimapp pushed a commit to neelimapp/napalm that referenced this pull request Mar 20, 2020
If BGP is not active (looking for specific strings in output), just
return an empty dictionary.  Update unit testing to allow for empty
dictionary returns (global key should only exist if the dictionary is
not empty). Closes napalm-automation#987
bharath-ravindranath pushed a commit to bharath-ravindranath/napalm that referenced this pull request Apr 19, 2020
If BGP is not active (looking for specific strings in output), just
return an empty dictionary.  Update unit testing to allow for empty
dictionary returns (global key should only exist if the dictionary is
not empty). Closes napalm-automation#987
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IOS BGP not active error
3 participants