Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1247 by making PEM naming consistent #1248

Merged
merged 3 commits into from Jul 1, 2020
Merged

Fix #1247 by making PEM naming consistent #1248

merged 3 commits into from Jul 1, 2020

Conversation

steffann
Copy link
Contributor

Fixes #1247

mirceaulinic
mirceaulinic reviewed Jun 30, 2020
View reviewed changes
Copy link
Member

@mirceaulinic mirceaulinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Would you be able to add a test case for this though? (To make sure all's good, remember to check by running tox locally)

@mirceaulinic mirceaulinic added this to the 3.0.2 milestone Jun 30, 2020
@steffann
Copy link
Contributor Author

steffann commented Jul 1, 2020

I added test data from one of my MX10k3 routers and removed some unwanted white space. Ready for review!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 2a6cc8b on steffann:patch-1 into 3e676cb on napalm-automation:develop.

mirceaulinic
mirceaulinic approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@mirceaulinic mirceaulinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great, thanks @steffann!

@mirceaulinic mirceaulinic merged commit cad362f into napalm-automation:develop Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirceaulinic mirceaulinic mirceaulinic approved these changes

Assignees
No one assigned
Labels
bug junos needs testcase
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

KeyError in get_environment() on Juniper MX10k3 with Junos 19.2R1.8
3 participants
@steffann @coveralls @mirceaulinic