Feature/nxos ssh get interfaces counters #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExaneServerTeam
force-pushed
the
feature/nxos_ssh_get_interfaces_counters
branch
from
54c2701
to
fa5b17c
Compare
mirceaulinic
reviewed
Sep 2, 2020
napalm/nxos_ssh/nxos_ssh.py
Outdated
|
|
||
| return all_stats_d | ||
|
|
||
| # print(counters_table_raw) |
napalm/nxos_ssh/nxos_ssh.py
Outdated
| 'rx_broadcast_packets': int, | ||
| """ | ||
| if_mapping = { | ||
| 'eth': { |
There was a problem hiding this comment.
I think Black doesn't like this, can you upgrade to the latest version then run black .
There was a problem hiding this comment.
@mirceaulinic Thanks for the review.
I fix it asap.
There was a problem hiding this comment.
@mirceaulinic Fixes on their way with latest push.
mirceaulinic
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
=Implements nxos_ssh get_interfaces_counters=