Add optional arguments support to IOSXR NETCONF driver #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the ability to pass in optional arguments to the iosxr_netconf driver. Note these are used as supplied and not passed through the netmiko_helpers base function.
1 task
mirceaulinic
approved these changes
Feb 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for optional args to isoxr_netconf.py driver to solve Issue #1394 ( IOSXR_NETCONF: Certain SSH arguments not supported). Optional arguments are used as supplied, as passing through the netmiko_args() function in netmiko_helpers for some reason removed some supplied (particularly 'hostkey_verify': False, 'look_for_keys': False) arguments, and I'm not able to work out why