Adds mac, ip checks for getters

[mundruid]

Adds mac / ip checks for:

get_lldp_neighbors
get_lldp_neighbors_detail
get_interfaces_ip
get_ntp_peers
traceroute
ping

Covers #451

[mirceaulinic]

It feels great align everything! Two changes requested, then should be able to get this in.

[mirceaulinic]

Instead of doing this regex check, I'd just apply the convert function instead, e.g.,

Suggested change

	r"^(\d|\w){4}.(\d|\w){4}.(\d|\w){4}$", entry["remote_chassis_id"]
	entry["remote_chassis_id"] = napalm.base.helpers.conver(napalm.base.helpers.mac, entry["remote_chassis_id"], entry["remote_chassis_id"])

[mundruid]

Thanks for the quick review and all the suggestions. Just checking: I agree with your suggestion, but if the chassis id cannot be converted, an empty chassis id will be returned. This is an example value from a chassis id from one of the tests:

In [75]: id = "hmbbkku-la"

In [76]: id = napalm.base.helpers.convert(napalm.base.helpers.mac, id)

In [77]: id
Out[77]: ''

Is that OK?

[mundruid]

I have addressed the comment with the latest commit. Let me know what you think @mirceaulinic

[mirceaulinic]

Yes, there should be a third argument, with the default, notice in the suggestion above:

entry["remote_chassis_id"] = napalm.base.helpers.conver(napalm.base.helpers.mac, entry["remote_chassis_id"], entry["remote_chassis_id"])

When unable to convert to the normalised MAC format, it'd default to the extracted value.

[mundruid]

Thank you for the help! Added.

[mirceaulinic]

Thank you @mundruid!