Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add var for remote system ip in lldp tpl #1577

Conversation

ratneshnagori
Copy link

Current textfsm ios template for show lldp neighbors details doesnt return remote system's mgmt ip. Editing this template to parse output of command to include mgmt ip as well.

@@ -17,7 +17,8 @@ Start
^System Description: -> Description
^System Description\s*-\s*${REMOTE_SYSTEM_DESCRIPTION}
^System Capabilities\s*?[:-]\s+${REMOTE_SYSTEM_CAPAB}
^Enabled Capabilities\s*?[:-]\s+${REMOTE_SYSTEM_ENABLE_CAPAB} -> Record
^Enabled Capabilities\s*?[:-]\s+${REMOTE_SYSTEM_ENABLE_CAPAB}
^\s+IP\:\s${REMPRT_SYSTEM_MGMT_IP} -> Record
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is remprt and where is this variable used?

Copy link
Author

@ratneshnagori ratneshnagori Mar 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually correct name is REMOTE_SYSTEM_MGMT_IP. I will correct it.

This variable is being used to get remote system's management ip which can be used to build a network topology. Once you have remote system's management ip, then you can log into it and find more devices downstream.

Copy link
Member

@mirceaulinic mirceaulinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are failing: https://github.com/napalm-automation/napalm/runs/6521163875?check_suite_focus=true#step:8:1199

Wrong format of TextFSM template show_lldp_neighbors_detail: Expected blank line after last Value entry. Line: 10.

@ratneshnagori
Copy link
Author

The tests are failing: https://github.com/napalm-automation/napalm/runs/6521163875?check_suite_focus=true#step:8:1199

Wrong format of TextFSM template show_lldp_neighbors_detail: Expected blank line after last Value entry. Line: 10.

Hi. Added a new line after var declaration - ratneshnagori@b5344e7

@mirceaulinic mirceaulinic modified the milestones: 4.0.0, BLOCKED Jul 11, 2022
@mirceaulinic
Copy link
Member

@ratneshnagori I'm afraid the tests are still failing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants