Handle modern memory output from Arista EOS 4.27+ #1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a new test case to |
Arista EOS 4.27+ (and possibly earlier versions, untested on 4.24-4.26) changes the output from `show processes top once` command, rendering values decimal numbers of MB instead of integer numbers of KB, and also reorders the fields. This commit extends the `get_environment` function with additional logic to handle the output from both older and newer OS versions. The memory expressed in MB is converted into KB for backward compatibility, but because the switch has done some rounding and displays only a limited number of decimal places, the conversion into KB will not be exact. There is nothing that Napalm can do about this. Includes test case for the new `show process top once` style output Fixes napalm-automation#1671
|
Test case added, and commit updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arista EOS 4.27+ (and possibly earlier versions, untested on
4.24-4.26) changes the output from
show processes top oncecommand, rendering values decimal numbers of MB instead of integer
numbers of KB, and also reorders the fields.
This commit extends the
get_environmentfunction with additionallogic to handle the output from both older and newer OS versions.
The memory expressed in MB is converted into KB for backward
compatibility, but because the switch has done some rounding and
displays only a limited number of decimal places, the conversion
into KB will not be exact. There is nothing that Napalm can do
about this.
Fixes #1671