Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix document build #1700

Merged
merged 7 commits into from
Jul 26, 2022
Merged

Fix document build #1700

merged 7 commits into from
Jul 26, 2022

Conversation

ktbyers
Copy link
Contributor

@ktbyers ktbyers commented Jul 12, 2022

No description provided.

@ktbyers
Copy link
Contributor Author

ktbyers commented Jul 12, 2022

There are a set of issues here:

  1. Jinja2 version 3.x has some compatibility issue with markupsafe. Since this is only for docs, I just forced the docs build to use Jinja2 version 2.x and a version of markupsafe that worked with it.
  2. py.test version7 changed the behavior of -c such that our "-c /dev/null" that we call in a couple of the .sh scripts in the docs dir no longer worked properly (i.e. the test rootdir was being set to /dev because of this). I temporarily fixed this by forcing py.test version 6.2.5.
  3. We have a coupling to napalm-ansible for some of the documentation build. Newer versions of ansible require Jinja2 >= 3.x. So for now, I just forced a somewhat older version of Ansible to be installed. It is only for the doc-build and the tests that are invoked there.

This at least gets docs building again.

I might try to improve on some of this (in the future), but let's at least do this so docs are building (and we are back in a known working state).

@ktbyers ktbyers changed the title Fix document build (do not merge) Fix document build Jul 12, 2022
@mirceaulinic mirceaulinic merged commit 9438938 into develop Jul 26, 2022
@mirceaulinic mirceaulinic deleted the fix_doc_build branch July 26, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants