Fix issue in lldp neighbors discovery for IOS devices. #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parsing logic incorrectly assumes that "remote_chassis_id" and "remote_port" will always contain MAC addresses
CarloMara
force-pushed
the
fix-ios-lldp-discovery
branch
from
f0cd3d0
to
59948a5
Compare
|
Hola @mirceaulinic, sorry for the direct tag, is there something I can do/missing to get this merged? Thanks a lot, |
|
Superseded by: #1849 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone,
The parsing logic incorrectly assumes that
remote_chassis_idandremote_portwill always contain MAC addresses. According to the spec this is not always the case.This pr adds the ability to handle uncommon cases, and a testcase to show the issue.
The data in the testcase was taken from a production device and anonymized (mac addresses and hostnames changed).
Thanks again for making Napalm, it's a godsend.
Cheers,
Carlo