Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding optional arguments for load_replace_candidate #508

Merged
merged 12 commits into from Nov 21, 2017
Merged

adding optional arguments for load_replace_candidate #508

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
51542db
adding optional arguments for load_replace_candidate and load_merge_c…
bharath-ravindranath Nov 10, 2017
9bc8837
Merge branch 'develop' into EOSDriver
bharath-ravindranath Nov 10, 2017
f37a3ab
adding optional argument 'autoComplete'
bharath-ravindranath Nov 10, 2017
7ea7889
adding optional argument 'autoComplete' changing failed tests
bharath-ravindranath Nov 10, 2017
e919984
Merge branch 'develop' into EOSDriver
bharath-ravindranath Nov 13, 2017
8f79704
making required changes as discussed
bharath-ravindranath Nov 14, 2017
11e8a5a
Merge branch 'develop' into EOSDriver
bharath-ravindranath Nov 14, 2017
eef353c
changing the if condition
bharath-ravindranath Nov 17, 2017
bcf98fb
Merge branch 'develop' into EOSDriver
bharath-ravindranath Nov 17, 2017
86b09e0
correcting the typo
bharath-ravindranath Nov 20, 2017
600c3f4
Merge branch 'develop' into EOSDriver
dbarrosop Nov 21, 2017
5bce3ce
Merge branch 'develop' into EOSDriver
dbarrosop Nov 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/support/index.rst
View file
Open in desktop
Expand Up @@ -125,6 +125,7 @@ ____________________________________
* :code:`alt_key_file` (ios, iosxr) - SSH host key file to use (if ``alt_host_keys`` is ``True``).
* :code:`keepalive` (junos, iosxr) - SSH keepalive interval, in seconds (default: ``30`` seconds).
* :code:`ignore_warning` (junos) - Allows to set `ignore_warning` when loading configuration to avoid exceptions via junos-pyez. (default: ``False``).
* :code:`eos_autoComplete` (eos) - Allows to set `autoComplete` when running commands. (default: ``None`` equivalent to ``False``)

The transport argument
______________________
Expand Down
7 changes: 6 additions & 1 deletion napalm/eos/eos.py
View file
Open in desktop
Expand Up @@ -88,6 +88,8 @@ def __init__(self, hostname, username, password, timeout=60, optional_args=None)

self.profile = ["eos"]

self.eos_autoComplete = optional_args.get('eos_autoComplete', None)

def open(self):
"""Implementation of NAPALM method open."""
try:
Expand Down Expand Up @@ -159,7 +161,10 @@ def _load_config(self, filename=None, config=None, replace=True):
commands.append(line)

try:
self.device.run_commands(commands)
if self.eos_autoComplete:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be if self.eos_autoComplete is not None in case False has to be enforced in the future.

self.devcie.run_commands(commands, autoComplete=self.eos_autoComplete)
else:
self.device.run_commands(commands)
except pyeapi.eapilib.CommandError as e:
self.discard_config()
if replace:
Expand Down