Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DON'T MERGE: Add framework to support commit confirmed #544

Closed
wants to merge 4 commits into from
Closed

DON'T MERGE: Add framework to support commit confirmed #544

wants to merge 4 commits into from
+75 −11

Conversation

ktbyers
Copy link
Contributor

@ktbyers ktbyers commented Nov 19, 2017

No description provided.

@ktbyers
Copy link
Contributor Author

ktbyers commented Nov 19, 2017

Reimplementation of napalm-automation/napalm-base#213

@ktbyers
Copy link
Contributor Author

ktbyers commented Nov 19, 2017

Originally created by @kderynski

@coveralls
Copy link

coveralls commented Nov 19, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 77.641% when pulling 6ef1308 on commit_confirmed2 into d5768ad on develop.

@ktbyers ktbyers changed the title Add framework to support commit confirmed DON'T MERGE: Add framework to support commit confirmed Nov 19, 2017
@ktbyers
Copy link
Contributor Author

ktbyers commented Nov 19, 2017

I want to test this some more to make sure we have the right abstractions.

@coveralls
Copy link

coveralls commented Nov 20, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 77.967% when pulling 935f359 on commit_confirmed2 into 6b6f128 on develop.

@ktbyers
Copy link
Contributor Author

ktbyers commented Nov 20, 2017 

  timer  commit session with a timeout. If not committed within this time, config will be reverted.
  <cr>

Software image version: 4.18.3.1F-2GB

@ktbyers
Copy link
Contributor Author

ktbyers commented Nov 20, 2017

This includes a proof-of-concept on implementing in Cisco IOS.

Note, I need to fix one of the methods as the name is wrong. Also I am not sure I want the confirm_abort method or whether we should just rely on the standard rollback method.

dbarrosop
dbarrosop reviewed Nov 21, 2017
View reviewed changes
napalm/eos/eos.py
"""Implementation of NAPALM method commit_config."""
if confirmed is not None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#512 (comment)

@ktbyers ktbyers mentioned this pull request Nov 22, 2017
Closed
@ktbyers ktbyers closed this Nov 22, 2017
@mirceaulinic mirceaulinic deleted the commit_confirmed2 branch May 6, 2020 11:09
@mirceaulinic mirceaulinic restored the commit_confirmed2 branch May 6, 2020 11:09
@mirceaulinic mirceaulinic deleted the commit_confirmed2 branch May 4, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbarrosop dbarrosop dbarrosop left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ktbyers @coveralls @dbarrosop