New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #695 - inconsistent use of domain name in LLDP #698
Conversation
@bdlamprecht Please review the test data that I included here and make sure you are okay with me including it (I scrubbed it a bit). |
Wow, that's a great turnaround time, much better than I anticipated! I see you changed the domain names and such, but I'd prefer to clean up some of the hostnames, IPv4 , and IPv6 addresses as well since this is going to be publicly available for the foreseeable future. The specific strings that I'd request to be altered are the following: I'm happy to cleanup the test data if you'd like me to. Let me know. |
@bdlamprecht Okay, see updated strings in the test data. Just let me know if anything else needs updated in the test data. |
That looks good, except you missed the line with the |
@bdlamprecht Okay, fixed. |
Great, that looks good. I appreciate it very much! |
+1 from me. Ran into this issue yesterday when writing a tutorial and using an old switch. This PR fixes the issue. Please merge. :) |
Cisco had an inconsistent use of domain name in LLDP brief (as compared to other IOS devices). This was causing a failure.