Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the use of deprecated inspect.getargspec() for inspect.getfullarg… #806

Merged
merged 2 commits into from
Sep 21, 2018
Merged

Fix the use of deprecated inspect.getargspec() for inspect.getfullarg… #806

merged 2 commits into from
Sep 21, 2018

Conversation

BoboTiG
Copy link
Contributor

@BoboTiG BoboTiG commented Sep 10, 2018

…spec() in netmiko_helpers.py

@coveralls
Copy link

coveralls commented Sep 10, 2018

Coverage Status

Coverage increased (+0.01%) to 79.068% when pulling 2713482 on BoboTiG:fix-inspect-warning into aa91264 on napalm-automation:develop.

@ktbyers
Copy link
Contributor

ktbyers commented Sep 10, 2018

Very minor lint issue that you need to fix (that is causing the unit tests to fail).

@BoboTiG
Copy link
Contributor Author

BoboTiG commented Sep 10, 2018

Good catch, done :)

@bewing
Copy link
Member

bewing commented Sep 10, 2018

# git grep -l getargspec
napalm/base/mock.py
napalm/base/netmiko_helpers.py
napalm/base/test/getters.py

Possibly worth moving this solution to base.util.py23 and importing it from there?

@ktbyers ktbyers merged commit 5610fdc into napalm-automation:develop Sep 21, 2018
@ktbyers
Copy link
Contributor

ktbyers commented Sep 21, 2018

Will separately fix the use in mock.py and in getters.py

@BoboTiG BoboTiG deleted the fix-inspect-warning branch September 21, 2018 20:20
ExaneServerTeam pushed a commit to ExaneServerTeam/napalm that referenced this pull request Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants