NX-OS refactor #833
Merged
NX-OS refactor #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ran napalm_custom_test on nxos and nxos_ssh for this updated driver. I also did quite a bit of testing using pdb and a real device. |
Closed
|
Added unit tests to test that automatic rollback on a failed merge operation worked properly for NX-OS (this is in the testing against real devices). Currently, I only ran it as a one off test; not running on an ongoing basis (it has to be merged into 'develop' before I can test on an ongoing basis). ktbyers/napalm_custom_test@37a961f#diff-16b358213f85e70673686e009a79b591R93 |
|
+1 I have reviewed the code briefly for a sanity check and have tested the PR changes against physical hardware. I used multiple getters for |
ExaneServerTeam
pushed a commit
to ExaneServerTeam/napalm
that referenced
this pull request
Mar 6, 2020
* Refactoring to use Netmiko SCP * Restructuring code to use Netmiko SCP * Consolidating common code. * Integrating nxos_ssh and nxos together better * Working on testing restructured code * Fixing decorator reference * Adding platform attribute; fixing decorator bug * Working on updating NXOS driver * Linting cleanup * Fixing bug with diff generation * More nxos consolidationg work * Linting cleanup * Removing some comments * Fix decorator and signature mismatch on test * Make nxos merge more atomic * Fix issue with not returning config change status * Fixing issue with sot_file overwrite * Fixing spelling * Fixing bug with nxos_ssh rollback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to release napalm 2.3.3 before merging this.
This is a big change to both the NX-OS drivers