Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize release notes to new mandatory labels #141

Merged
merged 1 commit into from May 25, 2023

Conversation

brisvag
Copy link
Contributor

@brisvag brisvag commented Apr 19, 2023

Description

Harmonizes our release notes to the new labels enforced by napari/napari#5733

Type of change

  • Fixes or improves existing content
  • Adds new content page(s)
  • Fixes or improves workflow, documentation build or deployment

cc @psobolewskiPhD

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 19, 2023
@Czaki
Copy link
Contributor

Czaki commented May 1, 2023

Single questions. We start having automated Pr (like napari/napari#5788). We want to exclude them from release notes (it they contains only constraints update, without code bugfixes)?

@psobolewskiPhD
Copy link
Member

I think better to put in maintenance?
I mean in some cases someone will have to fix a test, so there will be some real work even if PR is automated.

@Czaki
Copy link
Contributor

Czaki commented May 1, 2023

I think about two labels.

For example:

  • maintenance - included in release docs
  • automatic maintenance - not included in docs.

So if someone fixes the tests, then will change the label

@psobolewskiPhD
Copy link
Member

Is it worth the complexity? will people remember to change it? 👀

@brisvag
Copy link
Contributor Author

brisvag commented May 2, 2023

I'm for a single maintenance label, which goes in the notes. Most people will ignore that section anyways, so that's fine.

@psobolewskiPhD psobolewskiPhD merged commit 81608a6 into napari:main May 25, 2023
4 checks passed
@brisvag
Copy link
Contributor Author

brisvag commented May 26, 2023

@psobolewskiPhD did you also get around to deleting labels as we discussed?

@psobolewskiPhD psobolewskiPhD added this to the 0.4.18 milestone Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants