Pin npe2 version to match installed one #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
aganders3
approved these changes
Jun 8, 2023
Co-authored-by: Ashley Anderson <aganders3@gmail.com>
|
Does this affect the |
Czaki
commented
Jun 8, 2023
Comment on lines
+25
to
+26
| if not parse(npe2_version).is_devrelease: | ||
| check_call(f"git checkout tags/v{npe2_version}".split(), cwd=NPE) |
There was a problem hiding this comment.
This check disable checkout if development version of npe2 is installed in workflow. So it is enough to add pip install git+https://github.com/napari/npe2 to the workflow to have dev version of docs.
melonora
approved these changes
Jun 8, 2023
|
I will merge it not to restore working napari repo tests |
Czaki
added a commit
to napari/napari
that referenced
this pull request
Jun 21, 2023
Czaki
added a commit
to napari/napari
that referenced
this pull request
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The napari/npe2#294 breaks the docs building as we use the most recent npe2 repository, not matching npe2 version. In this PR I add
git checkout callto have the npe2 repository cloned in a version matching the installed npe2 version.Type of change
References
Final checklist: