Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getting started in napari linking to the unittest getting started page #217

Merged
merged 1 commit into from Aug 2, 2023

Conversation

seankmartin
Copy link
Contributor

@seankmartin seankmartin commented Aug 1, 2023

Clicking the Getting started grid in the below image pointed to https://docs.python.org/3/library/unittest.mock-examples.html#getting-started.
image

I've changed the link, so it should now link to https://napari.org/dev/tutorials/fundamentals/getting_started.html, which I assume was the intention here.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 1, 2023
Copy link
Member

@melissawm melissawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

Copy link
Member

@psobolewskiPhD psobolewskiPhD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, how'd that slip through!
Thanks

@psobolewskiPhD psobolewskiPhD added this to the 0.5.0 milestone Aug 2, 2023
@psobolewskiPhD
Copy link
Member

@melissawm should we consider making this fix as a patch in the live docs?

@melissawm
Copy link
Member

Happy to do that - once this is merged I can backport the changes to stable at least.

@psobolewskiPhD psobolewskiPhD merged commit b92f030 into napari:main Aug 2, 2023
7 checks passed
@melissawm
Copy link
Member

(I hope it's ok that I created a new label to keep track of what we want to backport to stable)

@psobolewskiPhD
Copy link
Member

awesome idea!

melissawm added a commit to melissawm/napari.github.io that referenced this pull request Aug 7, 2023
melissawm added a commit to melissawm/napari.github.io that referenced this pull request Aug 7, 2023
melissawm added a commit to melissawm/napari.github.io that referenced this pull request Aug 7, 2023
@jni jni modified the milestones: 0.5.0, 0.4.19 Aug 9, 2023
melissawm pushed a commit to melissawm/napari-docs that referenced this pull request Aug 15, 2023
psobolewskiPhD pushed a commit to napari/napari.github.io that referenced this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants