Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC Minor fixes to nap 6 doc #233

Merged
merged 3 commits into from Sep 15, 2023
Merged

DOC Minor fixes to nap 6 doc #233

merged 3 commits into from Sep 15, 2023

Conversation

lucyleeow
Copy link
Collaborator

@lucyleeow lucyleeow commented Aug 21, 2023 •
edited

Description

  • fix link to npe2 code
  • clarify that Layer would be a top level menu
  • fix yaml example
  • Add 'plugins' and 'layer context' menus to 'contributable' menus list

cc @DragaDoncila

Type of change

  • Fixes or improves existing content
  • Adds new content page(s)
  • Fixes or improves workflow, documentation build or deployment

References

Final checklist:

  • My PR is the minimum possible work for the desired functionality
  • I have commented my code, particularly in hard-to-understand areas
  • I have added alt text to new images included in this PR

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 21, 2023
DragaDoncila
DragaDoncila reviewed Aug 21, 2023
View reviewed changes
Copy link
Contributor

@DragaDoncila DragaDoncila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @lucyleeow just small change requests - one to make it clear that the layer right click menu is already open, and the other to remove the Plugins top level menu as that won't be open - only the plugin's own submenu within there.

docs/naps/6-contributable-menus.md Outdated
@@ -238,6 +238,9 @@ Layers
│ ├─ Tracks
│ ├─ Classification
Acquisition
Plugins

Layers context
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Layers context
Layers Context # already open for contribution

docs/naps/6-contributable-menus.md Outdated
@@ -238,6 +238,9 @@ Layers
│ ├─ Tracks
│ ├─ Classification
Acquisition
Plugins
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't add this here as the Plugins menu itself is not open for contribution - only the individual plugin's menu within there would be.

Copy link
Collaborator Author

@lucyleeow lucyleeow Aug 21, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, what about expanding to:
Plugins/<my_plugin> # only individual plugins submenu contributable

?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep @lucyleeow that works!

DragaDoncila
DragaDoncila approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@DragaDoncila DragaDoncila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lucyleeow, LGTM!

@lucyleeow
Copy link
Collaborator Author

Is this okay to go in? @DragaDoncila

@DragaDoncila DragaDoncila merged commit 08b6235 into napari:main Sep 15, 2023
5 of 6 checks passed
@DragaDoncila
Copy link
Contributor

@lucyleeow thanks for the ping! Done

@lucyleeow lucyleeow deleted the nap6 branch September 15, 2023 01:51
@psobolewskiPhD psobolewskiPhD modified the milestones: 0.5.0, 0.4.19 Oct 24, 2023
@psobolewskiPhD psobolewskiPhD mentioned this pull request Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DragaDoncila DragaDoncila DragaDoncila approved these changes

Assignees

@lucyleeow lucyleeow

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.4.19
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lucyleeow @DragaDoncila @psobolewskiPhD