Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sample database page #56

Merged
merged 2 commits into from
Dec 1, 2022
Merged

Conversation

chili-chiu
Copy link
Contributor

Description

Add publicly available (bio)image sample databases as further resources on napari.org.
Also to address this issue on napari.

Type of change

  • Bug-fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

References

How has this been tested?

  • example: the test suite for my feature covers cases x, y, and z
  • example: all tests pass with my change

Final checklist:

  • My PR is the minimum possible work for the desired functionality
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • If I included new strings, I have used trans. to make them localizable.
    For more information see our translations guide.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 22, 2022
Copy link
Contributor

@DragaDoncila DragaDoncila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chili-chiu I love this so much, just requested minor changes. Keen to have this in 🎉

docs/further-resources/sample_data.md Outdated Show resolved Hide resolved
docs/further-resources/sample_data.md Outdated Show resolved Hide resolved
@chili-chiu
Copy link
Contributor Author

thanks @DragaDoncila, addressed your two questions :)

Copy link
Contributor

@DragaDoncila DragaDoncila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those updates @chili-chiu !

@DragaDoncila DragaDoncila merged commit 05ace56 into napari:main Dec 1, 2022
@Czaki Czaki added this to the 0.4.18 milestone Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants