Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs for 5195 from main repository #7

Merged
merged 4 commits into from Nov 2, 2022
Merged

Docs for 5195 from main repository #7

merged 4 commits into from Nov 2, 2022

Conversation

Czaki
Copy link
Contributor

@Czaki Czaki commented Oct 14, 2022

Description

docs for napari/napari#5195

Type of change

  • Bug-fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

References

How has this been tested?

  • example: the test suite for my feature covers cases x, y, and z
  • example: all tests pass with my change

Final checklist:

  • My PR is the minimum possible work for the desired functionality
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • If I included new strings, I have used trans. to make them localizable.
    For more information see our translations guide.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 14, 2022
psobolewskiPhD
psobolewskiPhD reviewed Oct 14, 2022
View reviewed changes
Copy link
Member

@psobolewskiPhD psobolewskiPhD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small verbiage edits.

docs/plugins/debug_plugins.md Outdated Show resolved Hide resolved
docs/plugins/debug_plugins.md Outdated Show resolved Hide resolved
docs/plugins/debug_plugins.md Outdated Show resolved Hide resolved
docs/plugins/debug_plugins.md Outdated Show resolved Hide resolved
docs/plugins/debug_plugins.md Outdated Show resolved Hide resolved
docs/plugins/debug_plugins.md Outdated Show resolved Hide resolved
@Czaki @psobolewskiPhD
Apply suggestions from code review
09153da 
Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
@Czaki
Copy link
Contributor Author

Czaki commented Oct 15, 2022

Some small verbiage edits.

Thanks, If you find something more please point

melissawm
melissawm approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@melissawm melissawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny suggestions, otherwise looks good :)

docs/plugins/debug_plugins.md Outdated Show resolved Hide resolved
docs/plugins/test_deploy.md Outdated Show resolved Hide resolved
@Czaki @melissawm
Apply suggestions from code review
0a80bcc 
Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
@psobolewskiPhD
Copy link
Member

So now this approval maybe should be posted in napari/napari#5195 so the merging person also merges this? Cause I don't think we want either the code or docs PRs to get merged alone.

@Czaki Czaki mentioned this pull request Oct 27, 2022
Merged
12 tasks
@Czaki Czaki merged commit ac24a78 into napari:main Nov 2, 2022
@Czaki Czaki deleted the docs_main_thread_test branch November 2, 2022 09:38
@psobolewskiPhD psobolewskiPhD added this to the 0.5.0 milestone Jun 22, 2023
@psobolewskiPhD
Copy link
Member

Matching milestone to the napari PR.

@Czaki Czaki modified the milestones: 0.5.0, 0.4.18 Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psobolewskiPhD psobolewskiPhD psobolewskiPhD left review comments

@melissawm melissawm melissawm approved these changes

Assignees

@Czaki Czaki

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.4.18
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Czaki @psobolewskiPhD @melissawm