Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cards to usage landing pages #97

Merged
merged 2 commits into from
Feb 7, 2023

Conversation

melissawm
Copy link
Member

@melissawm melissawm commented Jan 27, 2023

Description

Adds cards to landing pages under the usage section. Organization, wording and the order of the cards can be changed according to the review.

Type of change

  • Fixes or improves existing content
  • Adds new content page(s)
  • Fixes or improves workflow, documentation build or deployment

References

Closes #87

Final checklist:

  • My PR is the minimum possible work for the desired functionality
  • I have commented my code, particularly in hard-to-understand areas
  • I have added alt text to new images included in this PR

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 27, 2023
Copy link
Member

@psobolewskiPhD psobolewskiPhD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great.
Love it.
Thanks!

Copy link
Contributor

@DragaDoncila DragaDoncila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some v minor nitpicks @melissawm! Looks great 🎉

:link: annotation
:link-type: ref

How to annoate images and videos using the napari points, labels, or shapes layers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
How to annoate images and videos using the napari points, labels, or shapes layers
How to annotate images and videos using the napari points, labels, or shapes layers

@@ -1,3 +1,4 @@
(annotation)=
# Annotation

This section contains tutorials showing how to annoate images and videos using the napari points, labels, or shapes layers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this isn't your typo but we should probably fix it now to say annotate not annoate

:link-type: ref

An overview of the napari *Layers*, the basic viewable objects that can be added to a viewer.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
An overview of the napari *Layers*, the basic viewable objects that can be added to a viewer.
An overview of the napari *Layers*, the basic viewable objects that can be displayed on the canvas.

I think this wording is much clearer. I know we have it as the former in the tutorial as well, but I'm a bit more ok with that since the whole doc then goes on to explain and give examples of what layers are.

@melissawm
Copy link
Member Author

Fixed - thanks for the review @DragaDoncila !

@psobolewskiPhD psobolewskiPhD merged commit 2724a35 into napari:main Feb 7, 2023
melissawm added a commit to melissawm/napari-docs that referenced this pull request Feb 10, 2023
# Description

Adds cards to landing pages under the usage section. Organization,
wording and the order of the cards can be changed according to the
review.

## Type of change
- [x] Fixes or improves existing content

# References
Closes napari#87

## Final checklist:
- [x] My PR is the minimum possible work for the desired functionality
@psobolewskiPhD psobolewskiPhD added this to the 0.4.18 milestone Jun 22, 2023
@melissawm melissawm deleted the usage-cards branch January 9, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create "cards" page to subitems in the Usage rubric
3 participants