Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maint] Improve contribution in README and remove pyqt5 from [dev] install dependency #188

Merged
merged 5 commits into from
Nov 27, 2023

Conversation

psobolewskiPhD
Copy link
Member

@psobolewskiPhD psobolewskiPhD commented Nov 25, 2023

Closes: #185
Closes: #168

I've removed pyqt5 from [dev] and added a Note in the Contributing section that you need a suitable Qt backend for napari. I've added an example using a conda virtual env and installing [dev] and PyQt5. Finally, I explicitly provide the command to run tests locally.

@jni
Copy link
Member

jni commented Nov 26, 2023

@psobolewskiPhD should we link to https://napari.org/dev/tutorials/fundamentals/installation.html?highlight=qt%20backend#choosing-a-different-qt-backend?

I'm using the dev link because backends seem to be something where updates can happen independently of the napari version.

@psobolewskiPhD
Copy link
Member Author

Sure I can add that. The gist is you need a functioning napari install, which means having a Qt backend. But if you have napari with pyside or pyqt6 or whatever this plugin shouldn't override that with pyqt5.

@psobolewskiPhD
Copy link
Member Author

I updated the PR (and OP) to add the requested link and to address #168 also.
The shell block followed by pytest . works for me locally--all green!--with this PR.

@psobolewskiPhD psobolewskiPhD changed the title [Maint] remove pyqt5 from [dev] install dependency [Maint] Improve contribution in README and remove pyqt5 from [dev] install dependency Nov 27, 2023
@jni jni merged commit 35e5acc into napari:main Nov 27, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Maintenance] re-consider [dev] PyQt5 dependency How to run the tests locally?
2 participants