Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to PyPI Trusted Publishing, and remove twine #212

Merged
merged 10 commits into from
Jun 6, 2024

Conversation

GenevieveBuckley
Copy link
Contributor

Closes #211

This PR switches to PyPI deployment with Trusted Publishing (see the announcement and how trusted publishing works). It removes twine, and also removes the need for PyPI API tokens being used as github secrets.

This PR is not sufficient on its own, someone else also needs to:

@GenevieveBuckley
Copy link
Contributor Author

PR marked as draft, so it doesn't get merged before someone enables trusted publishing on PyPI

@psobolewskiPhD
Copy link
Member

99% sure trusted published was enabled for this repo, but not sure how to check.

@alisterburt
Copy link
Collaborator

Just run it and see, no big deal if it fails!

@jni
Copy link
Member

jni commented May 24, 2024

it's enabled.

@jni
Copy link
Member

jni commented May 24, 2024

Just run it and see, no big deal if it fails!

loss aversion is powerful stuff. 😂

https://www.nytimes.com/interactive/2015/07/03/upshot/a-quick-puzzle-to-test-your-problem-solving.html

@GenevieveBuckley
Copy link
Contributor Author

CI tests failing, a fix is in progress here: #214

@alisterburt
Copy link
Collaborator

Just run it and see, no big deal if it fails!

loss aversion is powerful stuff. 😂

https://www.nytimes.com/interactive/2015/07/03/upshot/a-quick-puzzle-to-test-your-problem-solving.html

😆 thanks for this! Interesting read :)

pyproject.toml Outdated Show resolved Hide resolved
@GenevieveBuckley
Copy link
Contributor Author

PR #218 should fix the ruff CI errors

@GenevieveBuckley GenevieveBuckley marked this pull request as ready for review June 4, 2024 06:55
@jni
Copy link
Member

jni commented Jun 4, 2024

😆 thanks for this! Interesting read :)

@alisterburt did you pass the test? I am sad to admit that I was one of the 77% of chumps who confidently guessed powers of 2 after a bunch of positive tests. 😬

The crazy thing is that I consciously think about that test/article often, but still suffer from it. I'll spend so much time setting things up just-so, even when there is literally no cost to failure. But I deeply don't want the computer-says-no message! Stupid brain! 🧠 😂

@jni
Copy link
Member

jni commented Jun 4, 2024

@GenevieveBuckley wanna merge in main? 🙏 Then this should be ready to go in! 🚀

pyproject.toml Outdated Show resolved Hide resolved
@GenevieveBuckley
Copy link
Contributor Author

Ready to merge when the CI checks are all green.
Then we'll need someone to test a release candidate, to see if the PyPI trusted publishing works.

@jni jni merged commit ba8ab53 into napari:main Jun 6, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch deploy method to use trusted publisher
5 participants