Regression: Points.events.data is no longer fired from the data setter

[jni]

🐛 Bug

While investigating affinder CI failures, I found that #5967 broke affinder's tests. (btw if you've never heard of git bisect run you should try it! 😍) The reason is this line which removes the data event emitter from the setter but doesn't replace it with the new style.

It seems to have been simply missed. @melonora was this intentional? I can't imagine the reason for it other than an oversight! 😅

Fix incoming.

To Reproduce

import napari
import numpy as np


layer = napari.layers.Points(np.random.random((5, 3)))

layer.events.data.connect(lambda ev: print(ev))

print('adding a single point')
layer.add(np.random.random((1, 3)))  # prints ok

print('setting data')
layer.data = np.random.random((8, 3))  # nothing happens

print('done')

Result:

adding a single point
Event
setting data
done

Expected result (and result before 96516da):

adding a single point
Event
setting data
Event
done

Environment

napari main / napari 0.4.18.

[melonora]

oops 😲, this I believe is indeed an oversight. For sure it was not intentional.