Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

napari should not install "benchmarks" as a toplevel package #910

Closed
anntzer opened this issue Jan 27, 2020 · 1 comment 路 Fixed by #913
Closed

napari should not install "benchmarks" as a toplevel package #910

anntzer opened this issue Jan 27, 2020 · 1 comment 路 Fixed by #913
Labels
bug Something isn't working
Milestone

Comments

@anntzer
Copy link

anntzer commented Jan 27, 2020

馃悰 Bug

pip-installing napari not only creates a toplevel "napari" importable package, but also a spurious "benchmarks" package.

To Reproduce

Steps to reproduce the behavior:

In a clean venv, run pip install napari. Check that "benchmarks" has been installed as a toplevel package with e.g. python -c 'import benchmarks; print(benchmarks)'

Expected behavior

No such package installed.

Environment

This occurs when installing napari==0.2.10.

@sofroniewn sofroniewn added this to the 0.2.11 milestone Jan 27, 2020
@sofroniewn sofroniewn added the bug Something isn't working label Jan 27, 2020
@sofroniewn
Copy link
Contributor

sofroniewn commented Jan 27, 2020

Thanks for flagging @anntzer, this reminds me of #875 and would be good to fix alongside our other install improvements

ttung pushed a commit to ttung/napari that referenced this issue Jan 27, 2020
It's not meant to be packaged for distribution.

Fixes napari#910
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants