Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

automate release process #1138

Merged
merged 4 commits into from Apr 17, 2020
Merged

automate release process #1138

merged 4 commits into from Apr 17, 2020

Conversation

kne42
Copy link
Member

@kne42 kne42 commented Apr 13, 2020

Description

Automate the release process using GitHub Actions.

Upon pushing a tag beginning with v to napari/napari, the CI will:

  • copy the release notes to the tag
  • build the distribution
  • upload the distribution to the appropriate release on GitHub
  • upload the distribution to PyPI

@sofroniewn sofroniewn added the feature New feature or request label Apr 13, 2020
@sofroniewn sofroniewn added this to the 0.3.0 milestone Apr 13, 2020
sofroniewn
sofroniewn approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@sofroniewn sofroniewn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing! I love it!! As mentioned in our discussion, one line / a link about how to setup the pypi token on github for authentication added to our release notes would be great.

@codecov
Copy link

codecov bot commented Apr 14, 2020 •
edited

Codecov Report

Merging #1138 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1138   +/-   ##
=======================================
  Coverage   86.98%   86.98%           
=======================================
  Files         220      220           
  Lines       19379    19379           
=======================================
+ Hits        16856    16857    +1     
+ Misses       2523     2522    -1
Impacted Files Coverage Δ
napari/conftest.py 96.55% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 434d54e...555560d. Read the comment docs.

tlambert03
tlambert03 approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@tlambert03 tlambert03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! will be a nice addition to the pipeline :)

docs/developers/RELEASE.md Outdated Show resolved Hide resolved
.github/workflows/make_release.yml Outdated
echo "::set-env name=release_filepath::$RELEASE_FILEPATH"
- name: Create Release
id: create_release
uses: jbolda/create-release@v1.1.0 # switch to actions/create-release@latest once PR merged
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming you mean PR actions/create-release#50 ? can you add that url for easy lookup?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I included a shorthand instead of the full url, hope that's okay :)

@kne42
Copy link
Member Author

kne42 commented Apr 14, 2020

@jni When I made this, I didn't realize that we stopped uploading wheels to PyPI. Just because I'm curious, what's the advantage of this? Could you make a suggestion to this PR so that it does not build the wheels? Sorry, I'm not super experienced at packaging! :P

@jni
Copy link
Member

jni commented Apr 15, 2020

huh? We should definitely upload wheels, though they should be noarch. I can't remember how to limit wheels to certain Python versions, but that should be done also.

@sofroniewn
Copy link
Contributor

huh? We should definitely upload wheels, though they should be noarch

Maybe I've been messing up there, my bad - glad the new process will fix that. I'm very excited about this!!

jni
jni approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@jni jni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this. Thank you @kne42! What do you think about doing the same for scikit-image??? 😬😬😬😬

@jni jni merged commit 813890b into napari:master Apr 17, 2020
@kne42 kne42 mentioned this pull request Apr 17, 2020
Merged
@jni jni mentioned this pull request Apr 24, 2020
Closed
@rpanderson rpanderson mentioned this pull request May 3, 2020
Merged
@alexdesiqueira alexdesiqueira mentioned this pull request Nov 2, 2020
Open
@ericpre ericpre mentioned this pull request Mar 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlambert03 tlambert03 tlambert03 approved these changes

@jni jni jni approved these changes

@sofroniewn sofroniewn sofroniewn approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kne42 @jni @sofroniewn @tlambert03