-
-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move colormaps from layers folder to resources folder #156
move colormaps from layers folder to resources folder #156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Don't forget to change MANIFEST.in
. While you're at it, please also rename all instances of napari_gui
to napari
in there :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ressource folders are almost always reserved for non-code files such as icons, images, text files, etc...
I see a lot of python code going into the ressource folder, which i am not sure makes sense.
I am perfectly happy with colormaps living in a napari.colormaps package.
What would make sense to move to ressources is any text file (non .py) that would describe colormaps, if there is such a thing...
Ok, that sounds reasonable - does @jni want to weigh in before I move anything again? |
He does not. =P But he agrees with @royerloic's general gist. =) |
@royerloic how about a |
Have now moved to |
You are going to hate me... util packages usually contain utility methods and classes used internally multiple times. It is not a big deal at this point, we can revisit that later. |
IMO seeing as how these colormaps are specific to image layers, they should live in th3 |
Totally possible to colormap points, lines, shapes... =) |
(even desirable) |
These are all good points, we also need to curate the list of colors available for the marker I will leave this PR for now, but we can revisit when we address some of our other color related issues like #97 We might also want to look at the organisation of |
Description
Resolves #152.
Type of change
References
How has this been tested?
Final checklist: