Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-deprecated colormap in viewer cmap test #3043

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

jni
Copy link
Member

@jni jni commented Jul 14, 2021

Description

Fixes #3042

@github-actions github-actions bot added the tests Something related to our tests label Jul 14, 2021
@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #3043 (940af38) into master (0004f1a) will decrease coverage by 4.30%.
The diff coverage is 83.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3043      +/-   ##
==========================================
- Coverage   86.99%   82.69%   -4.31%     
==========================================
  Files         220      509     +289     
  Lines       19476    42586   +23110     
==========================================
+ Hits        16944    35216   +18272     
- Misses       2532     7370    +4838     
Impacted Files Coverage Δ
napari/_qt/containers/__init__.py 100.00% <ø> (ø)
napari/_qt/containers/_base_item_model.py 96.55% <ø> (ø)
napari/_qt/containers/_base_item_view.py 98.18% <ø> (ø)
napari/_qt/containers/_factory.py 87.50% <ø> (ø)
napari/_qt/containers/_layer_delegate.py 60.00% <ø> (ø)
napari/_qt/containers/_tests/test_factory.py 100.00% <ø> (ø)
napari/_qt/containers/_tests/test_qt_list.py 100.00% <ø> (ø)
napari/_qt/containers/_tests/test_qt_tree.py 100.00% <ø> (ø)
napari/_qt/containers/qt_layer_list.py 86.20% <ø> (ø)
napari/_qt/containers/qt_layer_model.py 75.00% <ø> (ø)
... and 585 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dd37ec...940af38. Read the comment docs.

Copy link
Contributor

@kevinyamauchi kevinyamauchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thanks, @jni !

I don't really understand the codecov change. That seems rather drastic for this one line change. Any thoughts @tlambert03 or @sofroniewn ?

edit: I see that it is comparing to 0004f1a (over 1 year old commit) for some reason?

Screenshot 2021-07-14 at 16 47 27

@sofroniewn sofroniewn added this to the 0.4.11 milestone Jul 14, 2021
Copy link
Contributor

@sofroniewn sofroniewn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sofroniewn sofroniewn merged commit d228e49 into napari:master Jul 14, 2021
@jni jni deleted the vispy-colormap-depr branch July 15, 2021 00:21
@jni
Copy link
Member Author

jni commented Jul 15, 2021

@kevinyamauchi I don't understand codecov's failings, and have decided to ignore them in most cases, sadly.

@tlambert03
Copy link
Contributor

wow, that one is particularly confusing :/ same here. no idea

@sofroniewn
Copy link
Contributor

also no idea from me :-(

@kevinyamauchi
Copy link
Contributor

Ha, well in any case, it makes me feel better to know that you all are just as confused as a I am!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Something related to our tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test error with vispy 0.7 (deprecated colormap)
4 participants