-
-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use non-deprecated colormap in viewer cmap test #3043
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3043 +/- ##
==========================================
- Coverage 86.99% 82.69% -4.31%
==========================================
Files 220 509 +289
Lines 19476 42586 +23110
==========================================
+ Hits 16944 35216 +18272
- Misses 2532 7370 +4838
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Thanks, @jni !
I don't really understand the codecov change. That seems rather drastic for this one line change. Any thoughts @tlambert03 or @sofroniewn ?
edit: I see that it is comparing to 0004f1a (over 1 year old commit) for some reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@kevinyamauchi I don't understand codecov's failings, and have decided to ignore them in most cases, sadly. |
wow, that one is particularly confusing :/ same here. no idea |
also no idea from me :-( |
Ha, well in any case, it makes me feel better to know that you all are just as confused as a I am! |
Description
Fixes #3042