Add extra garbage collection for some viewer tests #5108
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a special call to
gc.collect
to one of the viewer tests, so that anyViewer
andQtViewer
instances should not be present in future tests. That's particularly important for tests that callmake_napari_viewer
, which asserts that there are noQtViewer
instances.The hope is that this fixes the failing py310-windows-pyside2 tests on
main
. I was able to reproduce that failure and this fix did fix it.Type of change
How has this been tested?
Final checklist:
trans.
to make them localizable.For more information see our translations guide.