Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Update doc contributing guide #5114

Merged
merged 18 commits into from Oct 12, 2022
Merged

DOC Update doc contributing guide #5114

merged 18 commits into from Oct 12, 2022

Conversation

lucyleeow
Copy link
Contributor

Description

As discussed in a recent working group meeting:

We need to update the docs contributor’s guide to fully describe the “standard” contribution workflow of editable install + pull request, while still mentioning support for the “upload via web interface” workflow

Type of change

  • Bug-fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

References

How has this been tested?

  • example: the test suite for my feature covers cases x, y, and z
  • example: all tests pass with my change
  • example: I check if my changes works with both PySide and PyQt backends
    as there are small differences between the two Qt bindings.

Final checklist:

  • My PR is the minimum possible work for the desired functionality
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • If I included new strings, I have used trans. to make them localizable.
    For more information see our translations guide.

@github-actions
Copy link
Contributor

Click here to download the docs artifacts
docs
(zip file)

@github-actions
Copy link
Contributor

Click here to download the docs artifacts
docs
(zip file)

@github-actions github-actions bot added the qt Relates to qt label Sep 21, 2022
@lucyleeow lucyleeow removed the qt Relates to qt label Sep 21, 2022
@github-actions
Copy link
Contributor

Click here to download the docs artifacts
docs
(zip file)

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #5114 (737ab92) into main (6cf965e) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 737ab92 differs from pull request most recent head f78ba03. Consider uploading reports for the commit f78ba03 to get more accurate results

@@           Coverage Diff           @@
##             main    #5114   +/-   ##
=======================================
  Coverage   87.62%   87.62%           
=======================================
  Files         587      587           
  Lines       50049    50053    +4     
=======================================
+ Hits        43854    43859    +5     
+ Misses       6195     6194    -1     
Impacted Files Coverage Δ
napari/_qt/qt_viewer.py 78.23% <ø> (ø)
...layers/image/experimental/_chunked_image_loader.py 88.00% <0.00%> (-8.00%) ⬇️
napari/layers/image/_image_slice.py 97.61% <0.00%> (-2.39%) ⬇️
napari/layers/image/image.py 95.59% <0.00%> (-0.25%) ⬇️
napari/utils/stubgen.py 0.00% <0.00%> (ø)
napari/_tests/test_view_layers.py 98.31% <0.00%> (+0.02%) ⬆️
napari/utils/theme.py 89.79% <0.00%> (+0.68%) ⬆️
napari/utils/info.py 83.33% <0.00%> (+1.11%) ⬆️
napari/components/experimental/chunk/_pool.py 93.65% <0.00%> (+7.93%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions github-actions bot added the qt Relates to qt label Sep 21, 2022
@github-actions github-actions bot removed the qt Relates to qt label Sep 21, 2022
@lucyleeow lucyleeow changed the title WIP DOC Update doc contributing guide DOC Update doc contributing guide Sep 21, 2022
Comment on lines +167 to +169
If your documentation change includes code, it is important that you ensure
the code is working and executable. This is why you will need to have a
development installation of napari installed. [Examples](..../examples/README)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope this makes sense. We just need them to check that their code works right? It is not otherwise executed as part of doc build?

@github-actions
Copy link
Contributor

Click here to download the docs artifacts
docs
(zip file)

@github-actions
Copy link
Contributor

Click here to download the docs artifacts
docs
(zip file)

@github-actions
Copy link
Contributor

Click here to download the docs artifacts
docs
(zip file)

@github-actions
Copy link
Contributor

Click here to download the docs artifacts
docs
(zip file)

@github-actions
Copy link
Contributor

Click here to download the docs artifacts
docs
(zip file)

@github-actions
Copy link
Contributor

Click here to download the docs artifacts
docs
(zip file)

Copy link
Contributor

@DragaDoncila DragaDoncila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made just some small comments. I think it would be nice if people who just wanted to add their document via the github interface had an early exit from this document. Where you let them know they don't need to update the TOC I would just tell them to skip past previewing & running their code and just say "Open your PR and a member of the maintenance team will help with updating TOC & making sure docs build correctly. You'll also be able to preview this doc from a link posted on your PR". Or something like that


## 1. Download our template
Fork and clone [our repository](https://github.com/napari/napari). If you are
a0mending existing documentation, you can do so in your preferred text editor.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
a0mending existing documentation, you can do so in your preferred text editor.
amending existing documentation, you can do so in your preferred text editor.

## 3. Update TOC
* If you are amending an existing document you can skip straight
to [Step #3 - Preview your document](#3-preview-your-document)
* If you are adding new documentation and would prefer a simplier workflow,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* If you are adding new documentation and would prefer a simplier workflow,
* If you are adding new documentation and would prefer a simpler workflow,

@lucyleeow
Copy link
Contributor Author

I think it would be nice if people who just wanted to add their document via the github interface had an early exit from this document.

Good suggestion. I have updated but happy to amend?

@github-actions
Copy link
Contributor

Click here to download the docs artifacts
docs
(zip file)

@jni jni merged commit c305b46 into napari:main Oct 12, 2022
@lucyleeow lucyleeow deleted the doc_contrib branch October 13, 2022 00:09
@lucyleeow
Copy link
Contributor Author

Thanks!

@Czaki Czaki mentioned this pull request Jun 7, 2023
@Czaki Czaki added this to the 0.4.18 milestone Jun 7, 2023
@Czaki Czaki added the triaged-0.4.18 To mark PR that is triaged in 0.4.18 release process label Jun 7, 2023
Czaki pushed a commit that referenced this pull request Jun 16, 2023
Czaki pushed a commit that referenced this pull request Jun 17, 2023
Czaki pushed a commit that referenced this pull request Jun 18, 2023
Czaki pushed a commit that referenced this pull request Jun 19, 2023
Czaki pushed a commit that referenced this pull request Jun 21, 2023
Czaki pushed a commit that referenced this pull request Jun 21, 2023
Czaki pushed a commit that referenced this pull request Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation triaged-0.4.18 To mark PR that is triaged in 0.4.18 release process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants