New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Napari debugging during plugin development documentation #5142
Conversation
Hi all, please let me know what you think of this draft documentation for debugging during plugin development. I'm very open to any feedback and really appreciate it! |
Click here to download the docs artifacts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great @seankmartin, thank you so much for writing such a detailed doc 🎉 ! I've left a couple of small tweaky comments and a couple just requesting a few notes added.
Let me know if I can clarify anything!
Co-authored-by: Draga Doncila Pop <17995243+DragaDoncila@users.noreply.github.com>
- Remove section about warning menu - Add point about checking for entry point config - Add point about debugging with IDE - Link to code repo instead of inline code for starting point
Hi @DragaDoncila thank you so much for the detailed review, that's brilliant! I have incorporated all of the changes 😄. I guess the main things to double check I understood correctly:
Thank you again, and very happy to make further changes or discuss further. |
Just looking at my built docs, it seems that linking to the markdown docs didn't work in this case (Line 28): |
Click here to download the docs artifacts |
Click here to download the docs artifacts |
@seankmartin thank you for those updates, it's looking great!
Extra text is perfect! I should be more specific with my terms lol.
Hmm yeah, we don't really have a standardized solution for this. I think for now it's ok if it points to your personal one, but we probably want to provide a more general mechanism in the future. I don't think that should hold up this PR though.
Hmm yeah I'm not sure why that anchor link isn't working, I foolishly thought it might be the |
I'm not 100% sure, but I ran into something similar. Perhaps try: |
Click here to download the docs artifacts |
Hmm thanks for the suggestion @psobolewskiPhD, that doesn't seem to have worked either though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments, hope those are useful - let me know if I can help further!
Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
Hi @melissawm that's great, thank you so much for the help, much appreciated! 🎉 I was wondering, how do you find errors with the MyST parser? I built the docs locally before PR, but didn't notice the errors. Are there logs somewhere that you can check, or a command to run to find errors? |
@seankmartin the errors appear in the log of the docs build. Unfortunately we also get 300 other unrelated errors that mostly come from autosummary and the way it doesn't know how to deal with the napari codebase (this is autosummary's fault, not napari's!). Because I already know where to look, I can catch them in the sea of red messages 😅 |
@melissawm Thanks for the explanation, no wonder I didn't spot them! 😰 |
Just thinking about it now, I think I may have misunderstood the last suggestion regard the |
Hi @melissawm I think I have fixed the myst parser errors/warnings now, though perhaps I am still looking in the wrong place in the logs! Is this good to go if I have correctly fixed the myst parser errors/warnings? Please let me know if further changes are desired! |
Co-authored-by: Draga Doncila Pop <17995243+DragaDoncila@users.noreply.github.com> Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
Co-authored-by: Draga Doncila Pop <17995243+DragaDoncila@users.noreply.github.com> Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
Co-authored-by: Draga Doncila Pop <17995243+DragaDoncila@users.noreply.github.com> Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
Co-authored-by: Draga Doncila Pop <17995243+DragaDoncila@users.noreply.github.com> Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
Co-authored-by: Draga Doncila Pop <17995243+DragaDoncila@users.noreply.github.com> Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
Co-authored-by: Draga Doncila Pop <17995243+DragaDoncila@users.noreply.github.com> Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
Co-authored-by: Draga Doncila Pop <17995243+DragaDoncila@users.noreply.github.com> Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
Description
This PR adds a page to the the napari.org/plugins category about debugging plugins during development.
Type of change
References
closes #2948 closes #3735
Forum references:
Here is the code used in the docs
How has this been tested?
make docs
runs successfully and builds the docs as expected.Final checklist:
trans.
to make them localizable.For more information see our translations guide.