Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set selection color for QListView item. #5202

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Oct 12, 2022

Description

Set selection color for QListView item

Type of change

  • Bug-fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

References

it may closes #5200 but requires @haesleinhuepf confirmation

How has this been tested?

  • example: the test suite for my feature covers cases x, y, and z
  • example: all tests pass with my change
  • example: I check if my changes works with both PySide and PyQt backends
    as there are small differences between the two Qt bindings.

Final checklist:

  • My PR is the minimum possible work for the desired functionality
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • If I included new strings, I have used trans. to make them localizable.
    For more information see our translations guide.

@github-actions github-actions bot added the design Design discussion label Oct 12, 2022
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #5202 (05d816b) into main (2566980) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5202      +/-   ##
==========================================
- Coverage   88.81%   88.81%   -0.01%     
==========================================
  Files         574      574              
  Lines       48910    48910              
==========================================
- Hits        43441    43438       -3     
- Misses       5469     5472       +3     
Impacted Files Coverage Δ
napari/components/experimental/chunk/_pool.py 85.71% <0.00%> (-7.94%) ⬇️
napari/utils/theme.py 89.79% <0.00%> (+0.68%) ⬆️
napari/utils/info.py 83.33% <0.00%> (+1.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Czaki
Copy link
Collaborator Author

Czaki commented Oct 13, 2022

After manual check I could confirm that this solve the problem
obraz

@andy-sweet andy-sweet merged commit 8196109 into napari:main Oct 18, 2022
@Czaki Czaki deleted the bughix/use_highlight_in_list branch October 18, 2022 19:04
@Czaki Czaki mentioned this pull request Jun 7, 2023
@Czaki Czaki added the feature New feature or request label Jun 9, 2023
@Czaki Czaki added this to the 0.4.18 milestone Jun 9, 2023
Czaki added a commit that referenced this pull request Jun 16, 2023
Czaki added a commit that referenced this pull request Jun 17, 2023
Czaki added a commit that referenced this pull request Jun 18, 2023
Czaki added a commit that referenced this pull request Jun 19, 2023
Czaki added a commit that referenced this pull request Jun 21, 2023
Czaki added a commit that referenced this pull request Jun 21, 2023
Czaki added a commit that referenced this pull request Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design discussion feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-selection widget: Selection is hard to see
3 participants