New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests on release branch #5277
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5277 +/- ##
==========================================
+ Coverage 89.07% 89.08% +0.01%
==========================================
Files 581 581
Lines 49233 49233
==========================================
+ Hits 43853 43861 +8
+ Misses 5380 5372 -8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
+1, how would we notice failures ? A Bot posting comments ? I think the comprehensive failures on main branch are already mostly ignored, should have something more noticeable ? |
I think tak release manager will not ignore failures. In the context of main branch we need some responsible person that is hard if most persons are volunteering. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me!
Description
Based on this comment, I would like to enable tests when working with the release branch. I assume that such a branch will have the name in the format
v{release_number}x
as it happens for 0.4.16 and 0.4.17 releases.Type of change
References
How has this been tested?
as there are small differences between the two Qt bindings.
Final checklist:
trans.
to make them localizable.For more information see our translations guide.