Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on release branch #5277

Merged
merged 2 commits into from Nov 16, 2022
Merged

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Oct 27, 2022

Description

Based on this comment, I would like to enable tests when working with the release branch. I assume that such a branch will have the name in the format v{release_number}x as it happens for 0.4.16 and 0.4.17 releases.

Type of change

  • Bug-fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

References

How has this been tested?

  • example: the test suite for my feature covers cases x, y, and z
  • example: all tests pass with my change
  • example: I check if my changes works with both PySide and PyQt backends
    as there are small differences between the two Qt bindings.

Final checklist:

  • My PR is the minimum possible work for the desired functionality
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • If I included new strings, I have used trans. to make them localizable.
    For more information see our translations guide.

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #5277 (48aa054) into main (8a78b3c) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5277      +/-   ##
==========================================
+ Coverage   89.07%   89.08%   +0.01%     
==========================================
  Files         581      581              
  Lines       49233    49233              
==========================================
+ Hits        43853    43861       +8     
+ Misses       5380     5372       -8     
Impacted Files Coverage Δ
napari/layers/image/image.py 95.92% <0.00%> (+0.23%) ⬆️
napari/utils/theme.py 89.79% <0.00%> (+0.68%) ⬆️
napari/utils/info.py 83.33% <0.00%> (+1.11%) ⬆️
napari/layers/image/_image_slice.py 100.00% <0.00%> (+2.38%) ⬆️
napari/_qt/__init__.py 55.17% <0.00%> (+6.89%) ⬆️
...layers/image/experimental/_chunked_image_loader.py 96.00% <0.00%> (+8.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Czaki Czaki changed the title Remove circular import from _vispy Run tests on release branch Oct 27, 2022
@Carreau
Copy link
Contributor

Carreau commented Nov 1, 2022

+1, how would we notice failures ? A Bot posting comments ? I think the comprehensive failures on main branch are already mostly ignored, should have something more noticeable ?

@Czaki
Copy link
Collaborator Author

Czaki commented Nov 1, 2022

I think tak release manager will not ignore failures.

In the context of main branch we need some responsible person that is hard if most persons are volunteering.

Copy link
Contributor

@brisvag brisvag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me!

@andy-sweet andy-sweet merged commit 6bc76d5 into napari:main Nov 16, 2022
@Czaki Czaki deleted the run_test_on_release_branch branch November 16, 2022 22:48
@Czaki Czaki added the maintenance PR with maintance changes, label Dec 5, 2022
@Czaki Czaki mentioned this pull request Jun 7, 2023
@Czaki Czaki added this to the 0.4.17 milestone Jun 9, 2023
@Czaki Czaki modified the milestones: 0.4.17, 0.4.18 Jun 21, 2023
Czaki added a commit that referenced this pull request Jun 21, 2023
Czaki added a commit that referenced this pull request Jun 21, 2023
Czaki added a commit that referenced this pull request Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance PR with maintance changes, task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants