New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin mypy version #5310
Pin mypy version #5310
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, @Czaki!
types-PyYAML==6.0.12.1 | ||
types-setuptools==65.5.0.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see benefits from pin mypy
but I'm not sure if two others also should be pinned. On one side it reduces the probability of random error, on the other side, I do not remember errors with this packages. Maybe release this versions to reduce dependaboot PRs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree and vote to pin them. There is a strong advantage to having consistent type checking, so it is nice to make sure these packages don't change unexpectedly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I agree, I don't mind a few extra PRs if it means we don't get spurious unexpected failures.
Description
This PR pin mypy version is used for test typing and enabling dependaboot to create PR with updates of mypy related things.
This will allow us to not get unrelated failures in PR.
Type of change
References
How has this been tested?
as there are small differences between the two Qt bindings.
Final checklist:
trans.
to make them localizable.For more information see our translations guide.