Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin mypy version #5310

Merged
merged 3 commits into from Nov 8, 2022
Merged

Pin mypy version #5310

merged 3 commits into from Nov 8, 2022

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Nov 7, 2022

Description

This PR pin mypy version is used for test typing and enabling dependaboot to create PR with updates of mypy related things.

This will allow us to not get unrelated failures in PR.

Type of change

  • Bug-fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

References

How has this been tested?

  • example: the test suite for my feature covers cases x, y, and z
  • example: all tests pass with my change
  • example: I check if my changes works with both PySide and PyQt backends
    as there are small differences between the two Qt bindings.

Final checklist:

  • My PR is the minimum possible work for the desired functionality
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • If I included new strings, I have used trans. to make them localizable.
    For more information see our translations guide.

Copy link
Contributor

@kephale kephale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, @Czaki!

Comment on lines +2 to +3
types-PyYAML==6.0.12.1
types-setuptools==65.5.0.2
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see benefits from pin mypy but I'm not sure if two others also should be pinned. On one side it reduces the probability of random error, on the other side, I do not remember errors with this packages. Maybe release this versions to reduce dependaboot PRs?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree and vote to pin them. There is a strong advantage to having consistent type checking, so it is nice to make sure these packages don't change unexpectedly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I agree, I don't mind a few extra PRs if it means we don't get spurious unexpected failures.

.github/dependabot.yml Outdated Show resolved Hide resolved
@Czaki Czaki added the dependencies Pull requests that update a dependency file label Nov 8, 2022
@Czaki Czaki merged commit 8a78b3c into napari:main Nov 8, 2022
@Czaki Czaki deleted the pin_mypy branch November 8, 2022 19:35
@Czaki Czaki added this to the 0.5.0 milestone Nov 8, 2022
@Czaki Czaki added the maintenance PR with maintance changes, label Dec 5, 2022
@Czaki Czaki modified the milestones: 0.5.0, 0.4.18 Jun 19, 2023
Czaki added a commit that referenced this pull request Jun 19, 2023
@Czaki Czaki mentioned this pull request Jun 19, 2023
Czaki added a commit that referenced this pull request Jun 21, 2023
Czaki added a commit that referenced this pull request Jun 21, 2023
Czaki added a commit that referenced this pull request Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file maintenance PR with maintance changes, task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants