New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make all imports absolute #5318
Conversation
As I posted in the other thread, as a serious newbie I find the ... imports really confusing. When reading code I'm never sure where the import is from. Worse yet, I copy-paste a lot to try functions and such to see what they return and do, because I'm not good at reading the code. Then the .. imports don't work and I need to figure out what was intended. |
Codecov Report
@@ Coverage Diff @@
## main #5318 +/- ##
==========================================
+ Coverage 89.07% 89.09% +0.02%
==========================================
Files 581 581
Lines 49233 49233
==========================================
+ Hits 43853 43866 +13
+ Misses 5380 5367 -13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @Czaki ! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading up a bit, it seems that absolute imports are preferred by a large percentage of the Python community, and indeed by our own napari community, so 👍 from me. Thank you @Czaki and also everyone else who has contributed to this discussion!
This is gonna be a nightmare on all open PRs ^^' |
pre-commit action will solve most of problems |
Lets the conflicts start. |
Description
This is an alternative to #5308 where all imports are absolute
Type of change
References
How has this been tested?
as there are small differences between the two Qt bindings.
Final checklist:
trans.
to make them localizable.For more information see our translations guide.
cc @jni @kephale @goanpeca @psobolewskiPhD