-
-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For npe2 plugin, use manifest display_name for File > Open Samples #5351
Merged
DragaDoncila
merged 2 commits into
napari:main
from
psobolewskiPhD:plugin_display_for_open_samples
Nov 22, 2022
Merged
For npe2 plugin, use manifest display_name for File > Open Samples #5351
DragaDoncila
merged 2 commits into
napari:main
from
psobolewskiPhD:plugin_display_for_open_samples
Nov 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5351 +/- ##
==========================================
+ Coverage 89.04% 89.10% +0.05%
==========================================
Files 584 584
Lines 49393 49394 +1
==========================================
+ Hits 43983 44012 +29
+ Misses 5410 5382 -28
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jni
approved these changes
Nov 20, 2022
DragaDoncila
approved these changes
Nov 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 🎉 Thanks @psobolewskiPhD!
psobolewskiPhD
added a commit
to psobolewskiPhD/napari
that referenced
this pull request
Nov 23, 2022
psobolewskiPhD
added a commit
to psobolewskiPhD/napari
that referenced
this pull request
Nov 23, 2022
This was referenced Nov 23, 2022
Czaki
pushed a commit
that referenced
this pull request
Jun 16, 2023
…5351) * use manifest display_name for Open Samples menu * Add check in test
Czaki
pushed a commit
that referenced
this pull request
Jun 17, 2023
…5351) * use manifest display_name for Open Samples menu * Add check in test
Czaki
pushed a commit
that referenced
this pull request
Jun 18, 2023
…5351) * use manifest display_name for Open Samples menu * Add check in test
Czaki
pushed a commit
that referenced
this pull request
Jun 19, 2023
…5351) * use manifest display_name for Open Samples menu * Add check in test
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
…5351) * use manifest display_name for Open Samples menu * Add check in test
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
…5351) * use manifest display_name for Open Samples menu * Add check in test
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
…5351) * use manifest display_name for Open Samples menu * Add check in test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bugfix
PR with bugfix
tests
Something related to our tests
triaged-0.4.18
To mark PR that is triaged in 0.4.18 release process
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is the 2nd half to #5305 aiming to fix: #5304
![image](https://user-images.githubusercontent.com/76622105/202913755-57106bbb-dbe5-4fbe-b788-92fd6805c6a1.png)
It uses the
display_name
from the npe2 plugin manifest for the name of the plugin shown in the File > Open Sample menu. See:"Hello plugin" is shown instead of
napari-first-try
Type of change
References
Fixes #5304
See also the discussion here: napari/cookiecutter-napari-plugin#126
Also note that the napari-hub has started to use the
display_name
as well:chanzuckerberg/napari-hub#759 (comment)
How has this been tested?
as there are small differences between the two Qt bindings.
Final checklist:
trans.
to make them localizable.For more information see our translations guide.