Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unset PYTHON* vars and use entitlements in macOS conda menu shortcut #5354

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

jaimergp
Copy link
Contributor

Description

Type of change

  • Bug-fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

References

Needed for issues napari/packaging#50 and napari/packaging#38. Culminates work on napari/packaging#42

How has this been tested?

Final checklist:

  • My PR is the minimum possible work for the desired functionality
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • If I included new strings, I have used trans. to make them localizable.
    For more information see our translations guide.

@jaimergp jaimergp added the bundle An issue with the bundled executable app label Nov 22, 2022
Copy link
Contributor

@alisterburt alisterburt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @jaimergp !

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #5354 (ebd62d7) into main (8e5985a) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    napari/napari#5354      +/-   ##
==========================================
- Coverage   89.11%   89.11%   -0.01%     
==========================================
  Files         584      584              
  Lines       49465    49465              
==========================================
- Hits        44082    44081       -1     
- Misses       5383     5384       +1     
Impacted Files Coverage Δ
napari/components/experimental/chunk/_pool.py 85.71% <0.00%> (-7.94%) ⬇️
napari/utils/theme.py 89.79% <0.00%> (+0.68%) ⬆️
napari/utils/info.py 83.33% <0.00%> (+1.11%) ⬆️
napari/_qt/__init__.py 55.17% <0.00%> (+6.89%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jaimergp
Copy link
Contributor Author

Thank you both, that was quick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bundle An issue with the bundled executable app maintenance PR with maintance changes,
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants