Add parent when creating layer context menu to inherit application theme and add style entry for disabled widgets and menus

[dalthviz]

Description

Hi, this adds a missing parent kwarg so the layer context menu inherits the application theme (possible bug found while working on PR #5362). Also, add a style rule for disabled widgets (to for example show with a different style disabled entries on menus):

Preview

Layer context menu

Windows:

Before	After

MacOS:

Before	After

Ubuntu:

Before	After

Application menus

Windows:

Before	After

MacOS:

On macOS the application menus are integrated with the OS so the qss style doesn't change the way they look.

Ubuntu:

Before	After

Type of change

• Bug-fix (non-breaking change which fixes an issue)

References

How has this been tested?

• all tests pass with my change
• I check if my changes works with both PySide and PyQt backends
  as there are small differences between the two Qt bindings.

Final checklist:

• My PR is the minimum possible work for the desired functionality

[codecov]

Codecov Report

Merging #5381 (522035e) into main (8656715) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #5381      +/-   ##
==========================================
+ Coverage   89.09%   89.11%   +0.01%     
==========================================
  Files         597      597              
  Lines       50614    50614              
==========================================
+ Hits        45095    45103       +8     
+ Misses       5519     5511       -8     

Impacted Files	Coverage Δ
napari/_qt/containers/_layer_delegate.py	60.60% <0.00%> (ø)
napari/_qt/widgets/qt_viewer_status_bar.py	81.57% <0.00%> (-1.32%)	⬇️
napari/utils/theme.py	92.85% <0.00%> (+0.59%)	⬆️
napari/utils/info.py	81.44% <0.00%> (+1.03%)	⬆️
napari/_qt/__init__.py	56.66% <0.00%> (+6.66%)	⬆️
napari/components/experimental/chunk/_pool.py	93.65% <0.00%> (+7.93%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[psobolewskiPhD]

Ironically, because I use system for my napari I've never noticed the underlying issue.
However, for me this isn't working so well on macOS.
My OS is currently in dark mode, while napari has Light theme:
with this PR:

Without:

I think the old behavior doesn't look good, but is functional. The new behavior is hard to read.
Menus seem fine with this PR (I see no change in behavior vs main):

[brisvag]

I also never noticed... @psobolewskiPhD maybe you could block this with a negative review to avoid premature merging, since you have a mac and can check future changes!

[Czaki]

It looks like something was missing from qss, but it looks like macOS specific problem.

[dalthviz]

Thanks for the feedback @psobolewskiPhD ! Will check on macOS to see what I can do 👍

[dalthviz]

Updated the screenshots testing on Windows, macOS and Ubuntu. The current approach sets a style that works as far as I tested on all three. Thinking on alternatives, another approach could be to only set the parent kwarg for the context menu on Windows and Linux (so the system style context menu is shown on macOS). Any further feedback, suggestions and checks are appreciated!

Further changes were done

[psobolewskiPhD]

this PR	Live
	N/A it's system dark

I have a small preference for the live thinner border and the grey rather than black dividers — it's more native that way; see the menu screenshot above (note the border on macOS dark is also grey and not black). Not a blocker from me.
Edit: I prefer the darker look of the live Dark contextual menu as well, because it's more native, but that's in the eye of the beholder, so also not a blocker.

[dalthviz]

Thanks for the further feedback! Could you check with the new commit?

With them the context menu should look something like the following on macOS:

[dalthviz]

Trying to update the OP preview for the application menu, seems like the suggested style rules for QModelMenu doesn't apply to some application menus (like File) while for other menus is getting applied (like View):

File menu

View menu

Maybe some application menus are created in a different way than using QModelMenu/build_qmodel_menu ?

[psobolewskiPhD]

I think it may be related to the app-model menu roll out.
Some menus have been converted to use app-model, like View: #4826
and also Help: #4922
All menus will eventually be migrated, so if View and Help look correct, then eventually everything will look fine. (on my mac, all the menus look the same—native—so I can't check.)

Also my suggestion may have been a bit reckless, not sure that the menu code makes sense there? At the very least maybe a comment is worth adding—sorry I neglected this.

[dalthviz]

Thanks for the explanation! Will check adding the extra comment/changing the position for the QModelMenu styles. Probably moving them near the QMenuBar styles section or to the 02_custom.qss makes more sense?

Again thanks for all the help, reviews and suggestion done here! :)

[goanpeca]

Thanks for working on this @dalthviz 🚀

[Czaki]

Thanks for doing this :)