Maint: Typing and ImportError -> ModuleNotFoundError. #5431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Module not found is more specific than Import Error, and allows to bubble errors when the issue is not that the module is not installed. In the same vein it is an anti pattern to use try/except for conditional import, as it may hide errors in Python install, using a explicit compare with sys.version_info, can allow some tools (like pyupgrade) to detect dead branches.
Codecov Report
@@ Coverage Diff @@
## main #5431 +/- ##
==========================================
- Coverage 89.16% 89.10% -0.07%
==========================================
Files 584 597 +13
Lines 49515 50624 +1109
==========================================
+ Hits 44151 45107 +956
- Misses 5364 5517 +153
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
liu-ziyang
approved these changes
Dec 21, 2022
Czaki
approved these changes
Dec 21, 2022
brisvag
approved these changes
Dec 22, 2022
goanpeca
approved these changes
Dec 22, 2022
melissawm
pushed a commit
to melissawm/napari
that referenced
this pull request
Jan 11, 2023
Module not found is more specific than Import Error, and allows to bubble errors when the issue is not that the module is not installed. In the same vein it is an anti pattern to use try/except for conditional import, as it may hide errors in Python install, using a explicit compare with sys.version_info, can allow some tools (like pyupgrade) to detect dead branches.
Czaki
pushed a commit
that referenced
this pull request
Jun 16, 2023
Module not found is more specific than Import Error, and allows to bubble errors when the issue is not that the module is not installed. In the same vein it is an anti pattern to use try/except for conditional import, as it may hide errors in Python install, using a explicit compare with sys.version_info, can allow some tools (like pyupgrade) to detect dead branches.
Czaki
pushed a commit
that referenced
this pull request
Jun 17, 2023
Module not found is more specific than Import Error, and allows to bubble errors when the issue is not that the module is not installed. In the same vein it is an anti pattern to use try/except for conditional import, as it may hide errors in Python install, using a explicit compare with sys.version_info, can allow some tools (like pyupgrade) to detect dead branches.
Czaki
pushed a commit
that referenced
this pull request
Jun 18, 2023
Module not found is more specific than Import Error, and allows to bubble errors when the issue is not that the module is not installed. In the same vein it is an anti pattern to use try/except for conditional import, as it may hide errors in Python install, using a explicit compare with sys.version_info, can allow some tools (like pyupgrade) to detect dead branches.
Czaki
pushed a commit
that referenced
this pull request
Jun 19, 2023
Module not found is more specific than Import Error, and allows to bubble errors when the issue is not that the module is not installed. In the same vein it is an anti pattern to use try/except for conditional import, as it may hide errors in Python install, using a explicit compare with sys.version_info, can allow some tools (like pyupgrade) to detect dead branches.
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
Module not found is more specific than Import Error, and allows to bubble errors when the issue is not that the module is not installed. In the same vein it is an anti pattern to use try/except for conditional import, as it may hide errors in Python install, using a explicit compare with sys.version_info, can allow some tools (like pyupgrade) to detect dead branches.
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
Module not found is more specific than Import Error, and allows to bubble errors when the issue is not that the module is not installed. In the same vein it is an anti pattern to use try/except for conditional import, as it may hide errors in Python install, using a explicit compare with sys.version_info, can allow some tools (like pyupgrade) to detect dead branches.
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
Module not found is more specific than Import Error, and allows to bubble errors when the issue is not that the module is not installed. In the same vein it is an anti pattern to use try/except for conditional import, as it may hide errors in Python install, using a explicit compare with sys.version_info, can allow some tools (like pyupgrade) to detect dead branches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module not found is more specific than Import Error, and allows to bubble errors when the issue is not that the module is not installed.
In the same vein it is an anti pattern to use try/except for conditional import, as it may hide errors in Python install, using a explicit compare with sys.version_info, can allow some tools (like pyupgrade) to detect dead branches.