Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply disabled widgets style only for menus and set menus styles for QModelMenu and QMenu instances #5446

Merged
merged 1 commit into from Jan 11, 2023

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented Dec 26, 2022

Description

Apply disabled widgets style only for menus (QModelMenu or QMenu instances).

Preview (Windows):

menus

Type of change

  • Bug-fix (non-breaking change which fixes an issue)

References

closes #5445

How has this been tested?

  • all tests pass with my change
  • I check if my changes works with both PySide and PyQt backends
    as there are small differences between the two Qt bindings.

Final checklist:

  • My PR is the minimum possible work for the desired functionality

@dalthviz dalthviz self-assigned this Dec 26, 2022
@github-actions github-actions bot added the design Design discussion label Dec 26, 2022
@codecov
Copy link

codecov bot commented Dec 26, 2022

Codecov Report

Merging #5446 (774b483) into main (aebf02b) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5446   +/-   ##
=======================================
  Coverage   89.23%   89.23%           
=======================================
  Files         599      599           
  Lines       50884    50884           
=======================================
+ Hits        45405    45406    +1     
+ Misses       5479     5478    -1     
Impacted Files Coverage Δ
napari/components/experimental/chunk/_pool.py 85.71% <0.00%> (-7.94%) ⬇️
napari/_qt/qt_viewer.py 78.89% <0.00%> (+0.20%) ⬆️
napari/_qt/dialogs/qt_package_installer.py 81.67% <0.00%> (+0.39%) ⬆️
napari/utils/theme.py 92.85% <0.00%> (+0.59%) ⬆️
napari/utils/info.py 81.44% <0.00%> (+1.03%) ⬆️
napari/_qt/__init__.py 56.66% <0.00%> (+6.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@psobolewskiPhD psobolewskiPhD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks and works correct to me!

@dalthviz
Copy link
Member Author

Note: Seems like the failing check is related with test_qt_dims and #5443

Running the job again to see if this time passes

@psobolewskiPhD psobolewskiPhD merged commit afb70e3 into napari:main Jan 11, 2023
@Czaki Czaki mentioned this pull request Jun 7, 2023
@Czaki Czaki added the maintenance PR with maintance changes, label Jun 13, 2023
@Czaki Czaki added this to the 0.4.18 milestone Jun 13, 2023
@Czaki Czaki added enhancement maintenance PR with maintance changes, triaged-0.4.18 To mark PR that is triaged in 0.4.18 release process and removed maintenance PR with maintance changes, labels Jun 13, 2023
Czaki pushed a commit that referenced this pull request Jun 16, 2023
Czaki pushed a commit that referenced this pull request Jun 17, 2023
Czaki pushed a commit that referenced this pull request Jun 18, 2023
Czaki pushed a commit that referenced this pull request Jun 19, 2023
Czaki pushed a commit that referenced this pull request Jun 21, 2023
Czaki pushed a commit that referenced this pull request Jun 21, 2023
Czaki pushed a commit that referenced this pull request Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design discussion enhancement triaged-0.4.18 To mark PR that is triaged in 0.4.18 release process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Disabled opacity widget has wrong background
4 participants