Fix theme reference to get image for success_label style
#5447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalthviz
changed the title
success_label style
Codecov Report
@@ Coverage Diff @@
## main #5447 +/- ##
==========================================
- Coverage 89.23% 89.22% -0.01%
==========================================
Files 599 599
Lines 50884 50884
==========================================
- Hits 45405 45401 -4
- Misses 5479 5483 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Carreau
approved these changes
Jan 4, 2023
kne42
added a commit
to kne42/napari
that referenced
this pull request
Jan 9, 2023
* main: Bugfix: Ensure layer._fixed_vertex is set when rotating (napari#5449) Bugfix: Fix test_get_system_theme test for `name` to `id` change (napari#5456) Add correct `enablement` kwarg to `Split Stack` action, `Convert data type` submenu and `Projections` submenu (napari#5437) Add error color to themes and change application close/exit dialogs (napari#5442) Add auto canceling previous test after a new PR commit (napari#5453) Fix theme id reference to get image for 'success_label' style (napari#5447) Decouple changing viewer.theme from changing theme settings/preferences (napari#5143) [pre-commit.ci] pre-commit autoupdate (napari#5422) Configure `fail_on_no_env` for `tox-gh-actions` (napari#5408)
melissawm
pushed a commit
to melissawm/napari
that referenced
this pull request
Jan 11, 2023
Czaki
added
bugfix
Czaki
pushed a commit
that referenced
this pull request
Jun 16, 2023
Czaki
pushed a commit
that referenced
this pull request
Jun 17, 2023
Czaki
pushed a commit
that referenced
this pull request
Jun 18, 2023
Czaki
pushed a commit
that referenced
this pull request
Jun 19, 2023
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
idinstead ofnameto get the image forsuccess_label. Without that when updating other open PRs with the latest main branch I was getting the following warning interacting with the plugins dialog:Type of change
How has this been tested?
as there are small differences between the two Qt bindings.
Final checklist: