-
-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix _n_selected_points
in _layerlist_context.py
#5450
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Czaki
approved these changes
Dec 28, 2022
Thanks for find and fix |
Codecov Report
@@ Coverage Diff @@
## main #5450 +/- ##
=======================================
Coverage 89.22% 89.23%
=======================================
Files 599 599
Lines 50884 50884
=======================================
+ Hits 45400 45405 +5
+ Misses 5484 5479 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Carreau
approved these changes
Jan 4, 2023
Czaki
pushed a commit
that referenced
this pull request
Jun 16, 2023
Czaki
pushed a commit
that referenced
this pull request
Jun 17, 2023
Czaki
pushed a commit
that referenced
this pull request
Jun 18, 2023
Czaki
pushed a commit
that referenced
this pull request
Jun 19, 2023
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While going through the source code, I noticed that
_n_selected_points
counts the number of labels layers instead of the number of points layers (likely a copy-paste mistake). This minimal PR rectifies that.Type of change
References
None
How has this been tested?
I have NOT tested this.
Final checklist:
trans.
to make them localizable.For more information see our translations guide.