Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix _n_selected_points in _layerlist_context.py #5450

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

jwindhager
Copy link
Contributor

Description

While going through the source code, I noticed that _n_selected_points counts the number of labels layers instead of the number of points layers (likely a copy-paste mistake). This minimal PR rectifies that.

Type of change

  • Bug-fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

References

None

How has this been tested?

I have NOT tested this.

Final checklist:

  • My PR is the minimum possible work for the desired functionality
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • If I included new strings, I have used trans. to make them localizable.
    For more information see our translations guide.

@Czaki
Copy link
Collaborator

Czaki commented Dec 28, 2022

Thanks for find and fix

@codecov
Copy link

codecov bot commented Dec 28, 2022

Codecov Report

Merging #5450 (068e1da) into main (562cc7f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5450   +/-   ##
=======================================
  Coverage   89.22%   89.23%           
=======================================
  Files         599      599           
  Lines       50884    50884           
=======================================
+ Hits        45400    45405    +5     
+ Misses       5484     5479    -5     
Impacted Files Coverage Δ
napari/_app_model/context/_layerlist_context.py 91.13% <100.00%> (ø)
napari/_qt/dialogs/qt_package_installer.py 81.67% <0.00%> (+0.39%) ⬆️
napari/utils/theme.py 92.85% <0.00%> (+0.59%) ⬆️
napari/utils/info.py 81.44% <0.00%> (+1.03%) ⬆️
napari/_qt/__init__.py 56.66% <0.00%> (+6.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@brisvag brisvag merged commit 61782c0 into napari:main Jan 13, 2023
@jwindhager jwindhager deleted the patch-1 branch January 13, 2023 12:54
@Czaki Czaki mentioned this pull request Jun 7, 2023
@Czaki Czaki added this to the 0.4.18 milestone Jun 16, 2023
@Czaki Czaki added the bugfix PR with bugfix label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix PR with bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants